New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(knapsack): fix to knapsack asset set reference #2379

Open

owilliams320 wants to merge 1 commit into main from fix/knapsack-asset-set

Collaborator

owilliams320 commented Jan 31, 2025

Description

using default id from knapsack documentation. This seems to fix the reference issue causing all of the icons to fail

What's included?

adjusted the default id for the light theme per knapsack documentation

Test Steps

nx run knapsack:build
then navigate to the browser opened
finally test the icon web components example and any example using icons

General Tests for Every PR

npm run start still works.
npm run lint passes.
npm run stylelint passes.
npm test passes and code coverage is not lower.
npm run build still works.

Screenshots or link to StackBlitz/Plunker


          docs(knapsack): fix to knapsack asset set reference

369ba9d

owilliams320 deployed to covalent-pip-fix-knapsa-zt3jog

January 31, 2025 19:01

View deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet